Andrew Branch

Results 261 comments of Andrew Branch

Yes, that must be the same problem 👀 I have no idea how we didn’t notice this sooner. I guess we need to change how we do related spans and/or...

Here’s an example that’s sort of valid. It doesn’t convince me that the duplication is desirable:

Hey this is the second bisect today that blames #48837 😅

Does this still reproduce in typescript@next?

Edit: this was is not good advice. ESM and CJS entrypoints should _always_ have separate type declaration files. Any package.json `exports` structure with `types`/`import`/`require` and no nested conditions underneath them,...

Not being able to resolve dependency typings is only an error in `noImplicitAny`. It doesn’t work fine without `noImplicitAny`; the typings aren’t found and the import is silently `any`.

> if I remove `"type": "module"` from the package.json Are you referring to the dependency package.json or your own?

Assuming you’re talking about your own—when you import the dependency as ESM, the type lookup works due to TypeScript’s extension substitution. The export map is consulted, the `import` condition is...