Missing tags and test data in sdist

[jayvdb]

PyPI has 0.2.4 , with tests in the sdist, but no *.json test data files, so all tests pass when installing and testing from the sdist.

btw, you could pypi install and run check-manifest to build a complete MANIFEST.in.

GitHub has no tags at https://github.com/andrewbihl/bsed/releases, so I cant use that for fetching a usable tarball.

Would you be able to tag v0.2.4 in GitHub, so I can use it to get a complete archive, and finish packaging for openSUSE at https://build.opensuse.org/package/show/home:jayvdb:py-new/python-bsed . Or we can fix MANIFEST.in if you are intending to do a new release soon.

[andrewbihl]

@jayvdb Thanks for taking an interest in the project.

I added a release tag. I will update the MANIFEST.in before the next release.

I'm not familiar openSUSE. Who uses it/what's it for?

[jayvdb]

openSUSE is a Linux distribution which is similar to Fedora/RedHat.

Thanks, that has fixed the openSUSE versions which use Python 3.6 and 3.7 , however we have failures occurring on Python 3.4 , like

[   32s] ======================================================================
[   32s] ERROR: test_append_lines_starting_with_word (tests.test_append.TestAppend)
[   32s] ----------------------------------------------------------------------
[   32s] Traceback (most recent call last):
[   32s]   File "/home/abuild/rpmbuild/BUILD/bsed-0.2.4/tests/test_append.py", line 39, in test_append_lines_starting_with_word
[   32s]     func_name = inspect.stack()[0].function
[   32s] AttributeError: 'tuple' object has no attribute 'function'

If you dont intend to fix that, the classifiers and python_requires in setup.py need to be updated to prevent installation on Python 3.4 or lower

[andrewbihl]

@jayvdb I just released an update, pushed a new package to pip, and tagged the new version. Tests are now using the older inspect syntax for compatibility.

Thank you for catching that and for your patience--I've been particularly occupied recently and was not able to respond to this as promptly as I would normally like to.

[jayvdb]

I've submitted a PR for the remaining problem https://github.com/andrewbihl/bsed/pull/8 that I can see.

The next enhancement would be updating MANIFEST.in to include the LICENSE and tests especially in the sdist, and anything else worth archiving that check-manifest finds.