andrewbanchich
Fix GitHub actions workflow
Hi, could you split this up into different PRs? I'm not sure what issue you're addressing with "fix the workflow".
I think the Mac support looks good - it's just adding aarch64. But I don't know what the musl change is supposed to address.
Could you add more detail to what this fixes and split to two PRs please?
-------- Original Message -------- On 8/14/24 12:51 PM, aureliony - notifications at github.com wrote:
Fix the workflow and add support for mac silicon.
You can view, comment on, or merge this pull request online at:
https://github.com/andrewbanchich/shreddit/pull/102
Commit Summary
- b084153 Fix GitHub actions workflow
File Changes
(1 file)
Patch Links:
- https://github.com/andrewbanchich/shreddit/pull/102.patch
- https://github.com/andrewbanchich/shreddit/pull/102.diff
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>
Here are the details:
The current workflow is failing as the macos-latest runner now points to macos-14, which is arm64-based. macos-13 is still on x86_64.
About removing actions-rs: runners come with rustc and cargo preinstalled so we don't need to depend on actions-rs. Those actions have been deprecated.
About changing musl to gnu: runners don't come with musl preinstalled, so we'd get a musl not found error. Two solutions: switch to gnu or run sudo apt install musl only for linux. Personally, gnu is better because the workflow file won't be so messy and the compiled binaries are alot faster.
About mac silicon support: removed for now and won't make a new PR yet as it would conflict with this PR.