Andrew Azores comments

Results 209 comments of


                                            Andrew Azores

feat(reports): implement json-output automated report feature

I'll leave that up to you. I would prefer the 406 for now, and then the proper `.produces()` content-routing later will properly implement the negotiation and possibly change that behaviour...

feat(reports): implement json-output automated report feature

> Caused by: java.lang.NullPointerException: Cannot invoke "io.vertx.ext.web.ParsedHeaderValues.accept()" because the return value of "io.vertx.ext.web.RoutingContext.parsedHeaders()" is null I think this is saying that `ctx.parsedHeaders()` returning null is causing the chained `.accept()` call...

feat(reports): implement json-output automated report feature

```java ParsedHeaderValues phv = Mockito.mock(ParsedHeaderValues.class); Mockito.when(ctx.parsedHeaders()).thenReturn(phv); Mockito.when(phv.accept()).thenReturn(List.of(something, orOther)); ``` > I was trying to avoid mocking ParsedHeaderValues because I don't know how to instantiate it, but I'll try digging more....

feat(reports): implement json-output automated report feature

Yep. The return type of `.headers()` is a [MultiMap](https://vertx.io/docs/apidocs/io/vertx/core/MultiMap.html). We use that in various places already, ex.: https://github.com/cryostatio/cryostat/blob/main/src/test/java/io/cryostat/net/web/http/api/v2/AuthPostHandlerTest.java

feat(reports): implement json-output automated report feature

I think you could even use `.headers().contains("Accept", "text/html", true)` as a replacement for the new "parser" class.

feat(reports): implement json-output automated report feature

What about something like: ```java ParsedHeaderValues phv = ctx.parsedHeaders(); List accept = phv.accept(); boolean returnHtml = accept.stream().anyMatch(header -> header.component().equals("text") && header.subComponent().equals("html")) ``` If the `.contains("Accept", "text/html", true)` works then I...