Andrew Azores
Andrew Azores
There is an integration test that reacts to notifications in #1028: https://github.com/cryostatio/cryostat/blob/f225aab038ae1ae65cb422322aa33b2ec463fd56/src/test/java/itest/CustomTargetsIT.java
> there's probably no point in storing ActiveRecording metadata. If I'm understanding what you mean correctly, there is a point to storing it. The metadata in question is stuff that...
> I'm not sure how well the functionality propagates in the ITs since it's not the actual cryostat instance being tested and run on. Not sure what you mean here...
Ah right, that's something I had meant to clean up in the discovery PR. There is no more injectable `PlatformClient` - you can inject the `DiscoveryStorage` instead, which `implements PlatformClient`....
Could you tack on a quick integration test that just exercises the new `JFRConnection#getJvmId()` call? Just something that extends `ExternalTargetsTest`, deploys a couple of test containers, and then checks that...
I get logs like this when I try to start Cryostat with this patch applied: ``` Aug 23, 2022 8:47:18 PM io.cryostat.core.log.Logger error SEVERE: FAILED to deploy io.cryostat.recordings.RecordingMetadataManager Verticle java.lang.NullPointerException...
Also, not sure if this is a backend or frontend bug, but when I run this and https://github.com/cryostatio/cryostat-web/pull/473 together, I get a hanging GraphQL request when I try to visit...
> service:jmx:rmi:///jndi/rmi://uploads:9091/jmxrmi is uploads:9091 an actual service uri No, there is no target definition that would match this. There are subdirectories within the mounted `archive` directory named `file-uploads` and `uploads`,...
Once we have those new target-specific API endpoints, including one for uploading to archives specific to a target, I think we should actually remove the old v1 archive uploading endpoint....
And when we do that, I think we should just have a little migration function that moves anything from the existing unlabelled/generic archives into the archives owned by Cryostat itself,...