André R.

:) Your not the only one, but maybe a clear winner ;) What is your take on this PR and cleanups in general?

+1, ping @bdunogier

still ping @bdunogier :)

I think that failure has been fixed in the mean time, it is/was a unit test issue.

+1 but with same comments as @jeromegamez

@bdunogier Your right, it was mostly because it makes it easier to read the code later. But if you use closure you have to make sure variable is already declared,...

@joaoinacio: Good catch, it is not.

I assume this is still an issue, so with mode change and eZDir fix we should merge this.

Same here, if there was some new major/minor release planned and thus corresponding doc change it could make sense. But as there is not this is not something we'd put...

@joaoinacio .. would it be possible to just show the fix? why did you refactor this? it is quite hard to review when you change everything in the function, and...