André R.
André R.
ping @gggeek: Interesting micro optimization discussions, what do you think? :)
I would say -0.4 here, more settings means even more strange setups to support, and the gain seems to so close to zero you need a magnifying glass to see...
I'm generally against adding settings when not needed by now, and I'm also not for doing these kind of changes to legacy (changing paths) at this point as it is...
@jjCavalleri You seem to yourself say the patch is not correct, and your right, so from me -1 in current shape
> I'll pull the changes to inspect locally and proceed with removing the fork (if it is ok with eZ that I remove the forks) you can do what you...
+1 Review ping @bdunogier ( see also random cluster unit test failure again )
Seems to be valid change, the blame points to 84377457dea27afc6b0a6ce2281c11029771228f, where the issue was most likely introduced. But then maybe the change here should have instead been adapted: 34f347670e22ca15eb1d16a2eb03731cc99e62d7
The only issue with this is that _null_ is most likely sent by intention, null is supposed to be treated as using siteaccess settings for visibility at a deeper level,...
> Is it what you meant ? Exactly what I meant :)
It is ok as far as I can see. Besides the small comment above, there are some micro CS issues (missing empty new line after the new if blocks), and...