super-ml-pets icon indicating copy to clipboard operation
super-ml-pets copied to clipboard

Not saving best model

Open andreped opened this issue 3 years ago • 1 comments

The current checkpoint callback saves a model at a given step periodically. However, it is not necessarily the best model.

We should use the EvalCallback: https://stable-baselines3.readthedocs.io/en/master/guide/callbacks.html#evalcallback

andreped avatar Aug 20 '22 15:08 andreped

This was added here, but it fails due to issue https://github.com/andreped/super-ml-pets/issues/3.

As training occationally crash and we are unable to properly update the environment, forcing us to completely restart training, the EvalCallback will have the wrong behaviour.

andreped avatar Apr 04 '23 09:04 andreped