Add isort check in CI

Open andrenarchy opened this issue 5 years ago • 4 comments

Analogous to the linter, we should add an isort check to the workflow file.

Apr 26 '20 17:04 andrenarchy

And black. Assigning myself.

Apr 26 '20 18:04 nschloe

Black is already in there.

Apr 26 '20 18:04 andrenarchy

Ah yes. Well, isort and black are a little complicated (they contradict each other in minor details), see https://github.com/timothycrosley/isort/issues/694, https://github.com/psf/black/issues/333. I usually skip isort checks on CI. I haven't looked at this for a while so there may be a convenient solution by now.

Apr 26 '20 18:04 nschloe

Ah I see. Let me know if it does work. Otherwise, we can skip isort for now.

Apr 26 '20 18:04 andrenarchy