business-days-calculator icon indicating copy to clipboard operation
business-days-calculator copied to clipboard

Published 20 hours ago • verified publisher icon andrejsstepanovs

Updated dependency of phpunit

Open royopa opened this issue 7 years ago • 6 comments

Changed the version of dependency from phpunit to avoid conflicts.

royopa avatar Jan 22 '18 13:01 royopa

Will this be merged?

flynfish avatar Apr 04 '18 16:04 flynfish

@flynfish

The dependency "satooshi/php-coveralls": "~1.0" needs "phpunit/phpunit: ^4.8.35 || ^5.4.3 || ^6.0", so the composer.json containing the dependency " "phpunit/phpunit": "4.*"," causes a conflict that is corrected by this PR.

royopa avatar Apr 04 '18 23:04 royopa

@royopa i understand, I was trying to nudge @andrejsstepanovs to merge it 👍

flynfish avatar Apr 05 '18 16:04 flynfish

Please check why travis failed!

andrejsstepanovs avatar Apr 06 '18 00:04 andrejsstepanovs

Coverage Status

Coverage remained the same at 100.0% when pulling f2824109afd3ed2296d1395e0ea8be53b62b8e5b on royopa:patch-2 into 1b083be6222712c5d3e6d9ce26f394eb7a56aec1 on andrejsstepanovs:master.

coveralls avatar Apr 06 '18 11:04 coveralls

Coverage Status

Coverage remained the same at 100.0% when pulling f2824109afd3ed2296d1395e0ea8be53b62b8e5b on royopa:patch-2 into 1b083be6222712c5d3e6d9ce26f394eb7a56aec1 on andrejsstepanovs:master.

coveralls avatar Apr 06 '18 11:04 coveralls