periodic-table icon indicating copy to clipboard operation
periodic-table copied to clipboard
verified publisher icon andrejewski

added group and period to elements

Open asturur opened this issue 7 years ago • 4 comments

Hello, I was using this data for an exercise and i realized having group and period specified could have been handy

asturur avatar Apr 07 '18 09:04 asturur

Great pull, one note, cobalt has a group of 19 in your data rather than 9 and boron is showing as period 1, not two. Cheers!

tommyderami avatar Oct 04 '18 00:10 tommyderami

hey! i forgot about this. maybe i found a bad source? i ll double check.

asturur avatar Oct 04 '18 00:10 asturur

@asturur @eagletommy52 I can't accept this PR because the JSON file is built from the underlying CSV. I'm open to removing the CSV entirely to make collaboration easier, but that should be its own PR/discussion. Also, I highly encourage you both to check out #22 if you are interested in this project.

andrejewski avatar Oct 04 '18 05:10 andrejewski

ok i ll look better at the build process then. i do not remember what i did to be honest. was 6 month ago

asturur avatar Oct 04 '18 13:10 asturur