enki icon indicating copy to clipboard operation
enki copied to clipboard

Add Qt5 Webkit as a weak dependency on Fedora

Open abitrolly opened this issue 6 years ago • 14 comments

image

Would be nice to have editor working out of the box with all features.

abitrolly avatar Jul 22 '18 11:07 abitrolly

It is controversial topic. Some people prefer "batteries included", and some complain "Why do I have to download and install xxx MB of packages just to edit a little file. I would agree with you and install webkit out of the box. @rapgro, what do you think about it?

andreikop avatar Jul 23 '18 07:07 andreikop

xxx MB?

# dnf remove python3-qt5-webkit
Dependencies resolved.
======================================================================================
 Package                    Arch           Version              Repository       Size
======================================================================================
Removing:
 python3-qt5-webkit         x86_64         5.10-3.fc28          @fedora         571 k

Transaction Summary
======================================================================================
Remove  1 Package

Freed space: 571 k
Is this ok [y/N]: 

abitrolly avatar Jul 23 '18 07:07 abitrolly

Qt5 Webkit is not recommended. https://src.fedoraproject.org/rpms/enki/blob/master/f/enki.spec#_49

rapgro avatar Jul 23 '18 17:07 rapgro

This must be from an old release -- current Enki doesn't use webkit at all but the more modern QtWebEngine. @abitrolly, what release are you running?

bjones1 avatar Jul 23 '18 18:07 bjones1

Just installed python-qt5.qtwebengine on Linux Mint 19. It is +135 MB. (bindings + binaries + dependencies for binaries). Let's make it recommended dependency which is installed by default.

andreikop avatar Jul 23 '18 20:07 andreikop

This must be from an old release -- current Enki doesn't use webkit at all but the more modern QtWebEngine. @abitrolly, what release are you running?

This issue was forgotten to be closed https://github.com/andreikop/enki/issues/410 then? I am running 17.03.0 - https://apps.fedoraproject.org/packages/enki

abitrolly avatar Jul 23 '18 22:07 abitrolly

I just closed #410 -- thanks for pointing that out. It looks like there's not a release with the new non-QWebKit code it in. Perhaps @andreikop can produce one soon. However, code from git master doesn't use webkit.

bjones1 avatar Jul 23 '18 22:07 bjones1

Fixed with 19.10.0, no?

rapgro avatar Nov 17 '19 12:11 rapgro

Yes, If you updated Enki to 19.10.0 the issue is fixed.

andreikop avatar Nov 18 '19 08:11 andreikop

I didn't check, but I trust you. )

abitrolly avatar Nov 21 '19 15:11 abitrolly

Hey, @rapgro haven't updated Enki yet (probably). I hope he'll close the issue when updated.

andreikop avatar Nov 21 '19 15:11 andreikop

Sorry for the delay. I'm maintaining the Fedora package in my spare time, so I've to ask you to wait. Co-maintainers are of course welcome. See also #465 .

rapgro avatar Nov 21 '19 18:11 rapgro

nop, I just keep the issues open and assigned to have clear status and avoid re-opening and re-discussing the topic.

andreikop avatar Nov 22 '19 12:11 andreikop

#464 is a blocker for a new package in Fedora.

rapgro avatar Nov 23 '19 09:11 rapgro