cpp-channel icon indicating copy to clipboard operation
cpp-channel copied to clipboard

Published 20 hours ago • verified publisher icon andreiavrammsd

Refine iterator

Open bvbfan opened this issue 2 years ago • 3 comments

Small iterator refinition to be a bit more aligned to standard one.

bvbfan avatar Jun 17 '22 14:06 bvbfan

Hi, @bvbfan,

Thanks for taking the time to add your contribution!

I see you've introduced several changes that are not strictly related one to another. I would like to slowly introduce each change because I want to test and understand it. This is more of a learning project. You've addressed some issues that I postponed for a while so I could get the time to analyze them.

Is it possible to incrementally introduce each change on a different pull request? And ideally, there should be a measured or documented motivation for each change. If you don't have time, of course, it's no problem, and I will gradually take each of the aspects you addressed and introduce them to the project (mentioning your contribution).

andreiavrammsd avatar Jun 17 '22 14:06 andreiavrammsd

Feel free to split it. Just std::decay is shorten than existing one.

bvbfan avatar Jun 17 '22 15:06 bvbfan

Great, I will find the time for each one and introduce it.

Thanks again!

andreiavrammsd avatar Jun 17 '22 15:06 andreiavrammsd