BedWars1058 icon indicating copy to clipboard operation
BedWars1058 copied to clipboard

Published 20 hours ago • verified publisher icon andrei1058

Update fireball system

Open MherZaqaryan opened this issue 2 years ago • 11 comments

It's better to keep the fireball listers in one listener class file and also add a check which will check if the game has a playing status because in some cases addons' custom fireballs are being handled by these events and there is no way to prevent it.

MherZaqaryan avatar Apr 03 '22 11:04 MherZaqaryan

Is this still available?

andrei1058 avatar Dec 20 '22 18:12 andrei1058

Is this still available?

Yep! I am still getting messages from people about this issue being existential

MherZaqaryan avatar Dec 20 '22 18:12 MherZaqaryan

I heard that the current implementation caused issues with certain addons so it would be good to have this implemented, but it should be tested before release.

tomkeuper avatar Feb 27 '23 11:02 tomkeuper

@tomkeuper did you test it?

andrei1058 avatar Mar 06 '23 22:03 andrei1058

No I havent tested it. I was planning on making a build with this included when the 23.2.2 version is released. So poeple can test it before we merge it completely.

tomkeuper avatar Mar 07 '23 09:03 tomkeuper

@MherZaqaryan Could you merge the latest commits? I would like to test this the comming weeks

tomkeuper avatar Mar 27 '23 08:03 tomkeuper

Why this isn't merged?

itz-rj-here avatar Feb 15 '24 11:02 itz-rj-here

I see

itz-rj-here avatar Feb 15 '24 13:02 itz-rj-here

明白了

Sorry, I misread. This was actually not implemented

Lsy-291 avatar Feb 21 '24 09:02 Lsy-291

-_- seriously?..

itz-rj-here avatar Feb 21 '24 15:02 itz-rj-here

-_- seriously?..

Yes, this PR is to fix the bug in the Cosmetics addon. In this PR, a check of arena.getStatus() != GameState.playing is performed for fireball damage, cancelling the fireball damage after the game ends. In the current version, this has not been implemented.

Lsy-291 avatar Feb 21 '24 23:02 Lsy-291