net-core-push-notifications icon indicating copy to clipboard operation
net-core-push-notifications copied to clipboard
verified publisher icon andrei-m-code

Cache the private keys for less overhead when signing messages

Open danielgindi opened this issue 1 year ago • 2 comments

danielgindi avatar Sep 28 '24 17:09 danielgindi

@andrei-m-code gentle ping :-)

danielgindi avatar Oct 01 '24 07:10 danielgindi

Thank you @danielgindi please allow me some time to assess. I'm away for a couple of weeks, will try to get to it when I can

andrei-m-code avatar Oct 05 '24 17:10 andrei-m-code

@andrei-m-code This just celebrated its 1 year anniversary lol

danielgindi avatar Oct 16 '25 09:10 danielgindi

@danielgindi hey there! I just went through the code to celebrate the anniversary :), it seems like this has not much benefit as of today because for ApnSender we cache tokens per app bundle for 50 mins and for Firebase we do the same, we cache master token for an hour, so adding private key caching doesn't add a lot of perf benefit, given we already do what I've outlined above.

andrei-m-code avatar Oct 16 '25 15:10 andrei-m-code

You are correct, I missed that. Thank you!

danielgindi avatar Oct 17 '25 08:10 danielgindi