andrebrait
Multi-language support
Will do! It's on my plans. I need people to translate, though. I have, at this time, Italian, Brazilian Portuguese and English.
If you'd like to contribute or you know people who can, please point them to me.
Absolutely you can count on me. I already translated the original tool to Hungarian just never published.
@ViBE-HU @jsalatas I would appreciate! Can you add the translations to the JSON file in the /usr/lib/prime-indicator folder?
Attached (as txt as github doesn't allow me to attach json). I guess there might be some issues in the translation due to string concatenation, but I need to see these in action before I can tell for sure
@andrebrait not sure how to fork but I think I did it and made a commit (for the very first time lol). Notice me if I did it wrong.
@ViBE-HU You did it right! I jist merged your pull request! Thanks a lot!
@jsalatas the user @mugna91 changed some parts of the translations file. Would you mind checking if your translations are still correct when comparing to the latest version of the english strings? Thanks a lot!
Two messages were left out when the original file was created. @mugna91 added them a few hours ago. Can you guys please add the translations for those, when you find some spare time to do it? Thanks a lot!
@andrebrait I noticed this but I thought maybe you will remove these from the code for some reasons. The Logout button still missing, right?
I haven't been having much time to review these changes beyond a quick look in the pull request before merging. If the Logout button is still missing, we better add it because it appears a lot.
As for those messages, I don't plan to remove them unless there's a standardized way of logging out, and I don't think there is. So, since I don't plan to support every DE out there, it will always be possible for someone to be running an unsupported DE.
@andrebrait Of course. I just wanted to say that the string is missing from the json while it's in the code so you may want to add it also to the text files.
@andrebrait do you still need help with pt-br? I see you have pt-pt translations, and the messages are pretty much the same. But it is not complete, and I can send a patch anyway.
@gabrielssilva I'm brazilian, so I don't need help with the translation itself. However, I have been quite short in spare time lately, so it would be nice if you could send the patch :)
I was fairly inactive but I wanted to notice that the translation does not appears on Ubuntu. It's still use English somehow on my system. I also tested on a freshly installed laptop, but same happens.
Hey there, Vibe. Yeah, it has not been implemented yet. I have been busy lately. Sorry about that :/
Em 19 de abr de 2017 3:06 PM, "ViBE" [email protected] escreveu:
I was fairly inactive but I wanted to notice that the translation does not appears on Ubuntu. It's still use English somehow on my system. I also tested on a freshly installed laptop, but same happens.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/andrebrait/prime-indicator/issues/8#issuecomment-295371124, or mute the thread https://github.com/notifications/unsubscribe-auth/AFd-urGkuZFliRx9jaZD18FqYN9FVc1cks5rxk0ugaJpZM4Kd2N7 .