1g1r-romset-generator icon indicating copy to clipboard operation
1g1r-romset-generator copied to clipboard

older rom is favored

Open AlvaroBurnett opened this issue 3 years ago • 5 comments

When processing Genesis roms, the generator thinks that:

Lost Vikings, The (USA) (November, 1993)

is better than:

Lost Vikings, The (USA) (October, 1995)

AlvaroBurnett avatar Nov 16 '20 05:11 AlvaroBurnett

It currently doesn't have a distinction for dates. I can add it, though, as long as there's a formalized format for it.

andrebrait avatar Nov 16 '20 07:11 andrebrait

No-Intro is a bit inconsistent on dates. So far I've come across the following:

  • mm-dd-yyyy
  • mm-dd-yy
  • month name, yyyy

unexpectedpanda avatar Nov 18 '20 10:11 unexpectedpanda

@unexpectedpanda username checks out :D

Yeah, I can introduce support for that. It's not that hard. Just a few more regexes and one term in the comparation tuple.

However, I think it should come after any sort of versioning, if one is present, so v2 is preferred over v1 February, which is preferred over v1 January, for example.

Does that make sense?

andrebrait avatar Nov 18 '20 10:11 andrebrait

Out of nowhere :P

Yep. Versions/revisions are much higher in my parent selection process than date, so makes sense to me :)

unexpectedpanda avatar Nov 18 '20 10:11 unexpectedpanda

Ok, it's been a while but I'm finally gonna tackle this one this week

andrebrait avatar Jun 30 '21 18:06 andrebrait