laravel-api-to-postman icon indicating copy to clipboard operation
laravel-api-to-postman copied to clipboard

Fix collection merging bug

Open Menkveld-24 opened this issue 10 months ago • 5 comments

Scherm­afbeelding 2024-04-01 om 20 05 38

The ->put('url') overwrites the url part of the collection instead of adding to it upon GET requests.

Scherm­afbeelding 2024-04-01 om 20 06 30 Snippet run in tinkerwell now correctly merges the data into the collection

Would you also like me to extend the test for this? As the test only looks for the 'query' part inside the 'url'?

Menkveld-24 avatar Apr 01 '24 18:04 Menkveld-24

@Menkveld-24 good spot, and thanks for the PR. If you wouldn't mind extending the test surrounding this, that would be greatly appreciated 👍

andreaselia avatar Apr 01 '24 20:04 andreaselia

Hi, sorry for the late response. Been busy these weeks and kinda forgot about it. I'll try to do so this week

Menkveld-24 avatar Apr 15 '24 07:04 Menkveld-24

Hehe, I've finally made some changes. The test now checks the full get request instead of just the url query.

Also; saw this message about the deprecation of some tests or sth. Scherm­afbeelding 2024-05-01 om 12 04 02

Menkveld-24 avatar May 01 '24 10:05 Menkveld-24

@Menkveld-24 there's a failing test, are you able to fix it?

tomirons avatar May 01 '24 11:05 tomirons

Ofc! Somehow they didnt produce this error locally

Menkveld-24 avatar May 01 '24 12:05 Menkveld-24

@tomirons Should be good rn

Menkveld-24 avatar May 04 '24 11:05 Menkveld-24

Thank you @Menkveld-24 and @tomirons ❤️

andreaselia avatar May 06 '24 16:05 andreaselia