web-dialog icon indicating copy to clipboard operation
web-dialog copied to clipboard

Update web-dialog.ts

Open hansallis opened this issue 4 years ago • 0 comments

Hi,

First of all thanks for creating this module. I ran into an issue recently with Chrome. Instantiating a web-dialog element programmatically caused the following error: Uncaught DOMException: Failed to construct 'CustomElement': The result must not have attributes at <anonymous>:1:10

To mitigate this I've moved setting the aria-modal attribute from the constructor to the connectedCallback method.

Hope this constitutes an improvement.

Regards, Hans

hansallis avatar Jun 16 '21 14:06 hansallis