ocaml-graphql-server icon indicating copy to clipboard operation
ocaml-graphql-server copied to clipboard

Add CI check for ocamlformat

Open naartjie opened this issue 5 years ago • 4 comments

Ocamlformat has been added to the project via #177.

I'm opening up this issue to track the fact that we still need to add a CI check for it.

I had an initial look at it, but to be honest I don't really know how TravisCI works, nor the ocaml build pipeline in travis. If anyone has any suggestions or tips, please comment here, thanks.

naartjie avatar Dec 04 '19 17:12 naartjie

If it makes a difference, I'd be perfectly happy with a different CI setup also (Travis is very slow!), e.g. based on Github Actions, CircleCI or similar.

andreas avatar Dec 04 '19 19:12 andreas

here's a validation workflow from brisk-reconciler

https://github.com/briskml/brisk-reconciler/blob/d185e75c47b381fb911ca9decdf7525b97188ea1/.github/workflows/validate-pr.yml

wokalski avatar Dec 04 '19 19:12 wokalski

Great idea. GitHub actions sounds perfect for this.

naartjie avatar Dec 05 '19 11:12 naartjie

It even posts a comment when linter has spotted an issue. Amazing!

wokalski avatar Dec 05 '19 20:12 wokalski