ocaml-dataloader icon indicating copy to clipboard operation
ocaml-dataloader copied to clipboard

Published 20 hours ago • verified publisher icon andreas

opam release?

Open phated opened this issue 6 years ago • 5 comments

Hey @andreas, this project is great! Is there anything missing before it gets an opam release?

phated avatar Apr 23 '19 11:04 phated

Honestly I've found myself spread too thin, so I haven't found time to give the project much love 😬 Would you be interested in getting commit rights?

andreas avatar Apr 23 '19 20:04 andreas

@andreas totally understandable! I'm still new to the ocaml side of things (coming from reason) but I would love to help out where I can. I'm currently working on some example code using this library with ocaml-graphql-server and it's working great.

phated avatar Apr 24 '19 10:04 phated

That makes sense. I think this repo might be a good way to cut your teeth -- it's fairly small and self-contained, but still presents an opportunity to get experience with the entire flow of developing a package 😄 I've invited you as a collaborator now if you feel like it.

My suggested steps to a release would be:

  1. Update from jbuilder to dune
  2. Update to OPAM2 (this should fix Travis)
  3. Get a green build on Travis (hopefully requires no work after step 2)
  4. Publish

andreas avatar Apr 24 '19 19:04 andreas

@andreas great project! I'm not sure if @phated is still working on getting this but I managed to promote the project to dune and got travis to build as well. I'm also new to Ocaml as well 😄. If it's okay with you guys I can open a pr against this repo. My fork is located at https://github.com/selasiehanson/ocaml-dataloader

selasiehanson avatar Oct 19 '19 01:10 selasiehanson

@selasiehanson, sounds great. Please go ahead with the PR.

andreas avatar Oct 19 '19 10:10 andreas