AMWaveTransition icon indicating copy to clipboard operation
AMWaveTransition copied to clipboard

Published 20 hours ago • verified publisher icon andreamazz

Gestures cause cells to be misaligned

Open Sumukh opened this issue 11 years ago • 11 comments

Gestures

Is keeping track of the touch position necessary? The gesture recognizer could just trigger the normal transition?

Sumukh avatar Aug 15 '14 23:08 Sumukh

Hi @Sumukh Can you elaborate? How can I reproduce the issue?

andreamazz avatar Aug 28 '14 11:08 andreamazz

This behavior was triggered with a swipe from the left of the screen after selecting a row. Using that gesture causes the cells to be misaligned. I'll take another look at it soon.

Sumukh avatar Aug 28 '14 12:08 Sumukh

Which iOS version are you running?
Also, make sure that you are running the latest commit in the repo, IIRC that bug was fixed.
I'll push a new version on cocoapods.

andreamazz avatar Aug 28 '14 13:08 andreamazz

Ok, version 0.5.2 is up, looks like I forgot to push some changes, sorry.

andreamazz avatar Aug 28 '14 13:08 andreamazz

I just pulled and it has the same issue (on a left swipe). I should have mentioned that I'm on iOS 8.

Sumukh avatar Sep 01 '14 08:09 Sumukh

First and foremost: very nice library - good job.

I have the same problem here on iOS 8 Beta 5 (Xcode beta 6). Everything works fine as long as the interactiveTransition is not being used. It happens on the Demo app launched in the sim.

Is this an issue you're planning on looking into sometime soon?

Cheers,

cuva avatar Sep 04 '14 06:09 cuva

Hi.
Yes, right now in iOS8 the gesture is rather glitchy, I'll work on it in the next few days, it should be rather trivial. I'll keep you posted.

andreamazz avatar Sep 04 '14 06:09 andreamazz

Fantastic. Thanks for the update.

cuva avatar Sep 04 '14 06:09 cuva

To fix this behavior just place adding subview before kick cells of toVC, and replace [self.navigationController.view addSubview:toVC.view] with [self.navigationController.view insertSubview:toVC.view belowSubview:self.navigationController.navigationBar]; You can check my fork, branch "Sashke".

Sashke avatar Sep 11 '14 09:09 Sashke

Brilliant, thanks @Sashke, your fix works like a charm.
@Sumukh checkout the latest commit and let me know if the issue is gone.

andreamazz avatar Sep 15 '14 14:09 andreamazz

Hey @andreamazz

Thanks for fixing this, It indeed appears to fix the interactive issue on iOS8. However the fix above introduces a problem if using a navigation controller without a navigation bar.

It works just fine when using the back button, but the interactive back gesture doesn't behaves as expected. Please see the following minimal sample project for iOS 8 (I've applied manually the latest commit in the Pods dep): https://github.com/cuva/TestAMWaveTransition

I've tried to discover where it comes from but modifying the Y values didn't seem to make much change.

Cheers.

cuva avatar Sep 16 '14 09:09 cuva