Andrea Peruffo
Andrea Peruffo
@metacosm @iocanel @manusa I think there is still time and value to act on this issue, wdyt?
I took a look at this issue and cannot find a proper check to correctly include/exclude enum's instances. Specifically given the test here: https://github.com/sundrio/sundrio/blob/b7091f8fbe792596258d6bf3a10c05bc3a415bd4/adapters/api/src/test/java/io/sundr/adapter/testing/AbstractAdapterTest.java#L206 We include all the needed properties,...
@leoandrea7 couldn't find any way to discriminate the actual enum values from other properties :-(
@leoandrea7 right, but this is not generic enough to distinguish enum values from the rest as demonstrated in this comment: https://github.com/fabric8io/kubernetes-client/pull/4230#pullrequestreview-1020140603 i.e. any property that returns as Type the enum...
I don't think this case is infrequent, and anyhow, unfortunately, it's semantically incorrect. I would suggest that we move on fixing JsonIgnore behavior in enums so that there will be...
Submitted #4294 should provide a workaround also for this issue.
@manusa , yes, this PR is providing something different, but, to have a robust implementation we need to bubble up information changing `sundrio` first.
Hi @renannprado , thanks for opening this issue! Unfortunately, at the moment, generic types are not translated into the CRD, and is probably some major piece of work to actually...
Example: ```java class MyImplList extends List {} ... public static class MySpecArgs { @SchemaFrom(MyImplList.class) private final List myList; ```
@renannprado you are right, in the case of multiple implementations, it's not going to work. [Here](https://github.com/fabric8io/kubernetes-client/blob/master/doc/CRD-generator.md#generating-x-kubernetes-preserve-unknown-fields-true) you can find the documentation on how to automatically generate `x-kubernetes-preserve-unknown-fields`