pause icon indicating copy to clipboard operation
pause copied to clipboard

form to request PAUSE account has misleading full name help text

Open tmetro opened this issue 6 years ago • 6 comments

The form: https://pause.perl.org/pause/query?ACTION=request_id

under the "full name" field helpfully adds:

... This field is considered to be filled with both names, separated by a space. ...

pretty strongly implying that only "x y" format is accepted. But in actuality it can handle multiple words, and even some punctuation, like commas.

The help text should be updated to accurately reflect what is the acceptable format.

tmetro avatar Jul 13 '18 16:07 tmetro

Look at the actual code: https://github.com/charsbar/pause/blob/mojo_wip/lib/pause_2017/PAUSE/Web/Controller/Public/RequestId.pm#L55

or the code in the past: https://github.com/andk/pause/blob/master/lib/pause_1999/edit.pm#L2876

and the commit that mattered: https://github.com/andk/pause/commit/4c11985a38485e4890e2d09bbd576df3a5797ccc

It really expects only a white space in the field, to exclude a spam entry as clearly stated in the note (since 2012; people registered before may have no white space in their fullname, like GUGOD (劉康民). See https://metacpan.org/author/GUGOD ).

Do you still think we need to add some extra note?

charsbar avatar Jul 13 '18 17:07 charsbar

It could simply say "multiple" names instead of "both".

Grinnz avatar May 03 '19 17:05 Grinnz

That would suggest it’s referring to multiple names, which isn’t true. It’s referring to all parts of the name.

ap avatar May 03 '19 23:05 ap

"both" already suggests that except that it's referring to the "first name" and "last name" mentioned earlier, but "all parts of the name, separated by spaces" works for me.

Grinnz avatar May 03 '19 23:05 Grinnz

@charsbar:

Look at the actual code:

I believe that was his point: the code does one thing, but the documentation suggests another thing.

This problem still exists. The current form template lib/pause_2017/templates/public/request_id/_form.html.ep as it exists in master today contains this explanatory note:

Note: PAUSE has been developed in a time when it was more common than today that people have names consisting of at least a first name and a second name, like Ben Cartwright or Tony Nelson, you get the idea. This field is considered to be filled with both names, separated by a space. This trivial expectation was then coded into the server side sanity check of this form and it turned out to be a super efficient spam protection because bots often did not try to enter a space in the middle of the field. It was about the year 2003 when people started to complain that they had tried Peter and it did not work. Poor Peter, please remember you do have a second name.

Note that the “both names” text is still there. And it still doesn’t tell the user what exactly the code expects.

But also… I am willing to bet money that the last sentence was written by Andreas, in which case I can exactly imagine the good-natured, slightly mischievous, apologetic tone implied (and I am quite amused by it 🙂) – but I also believe that without the context of having met him, the tone of this text will read as condescending / patronising to users. 🙁

@andk: Maybe something like this?

Note: You can enter fairly free-form text here but it must consist of at least two space-separated words. This is a spam protection measure we discovered accidentally. Back when PAUSE was developed in the nineties, people would generally fill out a field asking for a full name with a first name and a second name, like Ben Cartwright or Tony Nelson. When this trivial expectation was coded into the server as a sanity check, it turned out to block many spam bots because they often did not try to enter a space in the middle of the field. It was only around 2003 that people started complaining that they had tried Peter and it did not work. Apologies for insisting, Peter – but feel free to make something up to satisfy the requirement.

ap avatar May 03 '19 23:05 ap

obligatory link :) https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/

karenetheridge avatar May 04 '19 00:05 karenetheridge

@ap: thanks for the suggestion, I like it.

andk avatar Apr 29 '23 14:04 andk

Thanks.

charsbar avatar Apr 29 '23 15:04 charsbar