andig

Results 2115 comments of andig

From the discussion it seems not required atm.

Thank you for this comprehensive PR! At this time, I'd not be too eager to merge: - +1k LoC is a lot of code to maintain- core team won't be...

Seems this has just doubled it to 2k LoC. If you see any option of hiding these LoC in an external module I'd be happy to reconsider.

> panic: processing template 'tariff/esios.yaml' failed: template 'esios-tariff-api': param region: description too long (84/50 allowed)- use help instead

> While traveling my web browser client is in a different timezone than my charger and auto. I'm not sure this is something worth fixing. How often would one charge...

@naltatis this is a niche case. Either UI shows backend timezone or we should close here. No priority.

> If this happens, my configured recurring charging plan is not executed. It's sufficient to identify the vehicle (or select it in the UI) for the planner to work. It...

> go version to the one currently used i in evcc (1.25), That lead's to double maintenance. It would make more sense of fix the compatibility issues instead of pinning...

Depends on https://github.com/CJNE/ha-porscheconnect/issues/242

Looks like a full rewrite. We'll need a MITM trace of the vehicle communication or someone must re-engineer what the HA plugin does.