andig

Results 723 comments of andig

For my purposes I've added these two cases to the parser: case 'X-ADDRESSBOOKSERVER-KIND': $cardData->xabkind = $value; break; case 'X-ADDRESSBOOKSERVER-MEMBER': if (!isset($cardData->xabmember)) { $cardData->xabmember = []; } $cardData->xabmember[] = $value; break;

This PR changes all indents which makes it very hard to follow what the actual changes are. Would you want to clean up and also add a screenshot? Is it...

Did you see https://stackoverflow.com/questions/50840168/how-to-detect-if-the-os-is-in-dark-mode-in-browsers#50843966. It would be nice to only have a manual setting when not running on OSX?

CSS variables only work as of Edge 15, released 2017. I guess that's acceptable?

> Do you think it makese sense to update the icons too? Maybe to fontawesome or something else? I would *really* love to replace our icons with an SVG icon...

Personally, I don't like the new striped table look (especially inside dialog boxes). I didn't have time yet to check the look on Mac but isn't the redesigned slider another,...

I tend to not merge this PR. A goal of UI refactoring was to get rid of the settings in an effort to make the UI cleaner. This PR introduces...

> What did you mean with "This PR introduces another setting"? The toggle switch to manually enable/disable the dark mode? Or the line in options.js? The switch > I don't...

just use `php` and hope for `composer:2` matching the currently best php version?