andig
I guess comments are a problem when sorting?
Friendly ping @frzifus. This would be really helpful using the module downstream and cross-goroutines. The diff looks bigger than it is as I've moved the ...Client routines above the respective...
Any chance for feedback on this change?
Friendly ping. This PR is needed to make a modbus connection usable from multiple goroutines, one per id.
ping @frzifus did you get a chance to review?
ping @frzifus any chance to take a look? Imho this really is a smallish change, although the diff looks large.
> Since users may initialized handlers without the new... functions, I would consider it to mark it as breaking change. wdyt? That's a good point. Not doing so will be...
If anybody wants to test this, I've created a fork at https://github.com/evcc-io/modbus. Happy to update this PR if interest arises.
While is PR is meanwhile severely bit-rotten and for sake of reference, we've been successfully using this with [evcc.io](https://evcc.io) for ~3 months now and are happy to report that we...
Thank you @hnicolaysen for the kind words. Lets please try to get https://github.com/grid-x/modbus/pull/93 merged, then I can update this PR with the remaining fixes. As @frzifus pointed out- though as...