dirhash-python icon indicating copy to clipboard operation
dirhash-python copied to clipboard

Mypy support

Open matthewrfennell opened this issue 6 months ago • 2 comments

Would you be interested in me raising a PR to add mypy types to this library?

I'm using this library in a project I'm currently working on which runs mypy across the codebase. Currently, I have to instruct mypy not to check types coming from this library - but adding types to this library would let me remove this override.

PS - thanks for this library and the dirhash standard, it makes it so easy to generate hashes and be confident they will be consistent across environments.

matthewrfennell avatar Jan 01 '24 12:01 matthewrfennell

Hey @matthewrfennell Thanks for dropping by :) as of https://github.com/andhus/dirhash-python/issues/9 I have very little time to maintain this unfortunately, but if you're willing to do so I'll find the time to review ...worried however that there might be some unrelated "blockers" (like Travis not running anymore etc.) that could slow it down. Haven't touched this in a long time and it could definitely use some spring cleaning.

andhus avatar Jan 04 '24 22:01 andhus

Ok, thanks a lot for getting back! I need to get approval from my employer before contributing, so I'll start filling out the paperwork now :) but, hopefully it'll get accepted. It may be a few weeks before I hear back from them - in the meantime I'll see if I can get it working locally. Once I have a PR, if I can be of help for sorting out Travis or some other blockers, then I'd be happy to help there too! But no pressure either way.

matthewrfennell avatar Jan 05 '24 18:01 matthewrfennell