Edgar Andrés Margffoy Tuay

Results 148 comments of Edgar Andrés Margffoy Tuay

@zzzeek thanks for the follow-up, I might need to take a look to the test, maybe there's a function that is declared as thread-unsafe and it's not being reported?

@rgommers this one is ready for review!

Thanks for the review @rgommers! I'll answer your questions as follows: > Most of the @pytest.mark.parallel_threads(1) indicate places where functionality isn't thread-safe apparently. What was the strategy for choosing to...

> adding a thread_unsafe marker to make that clearer We could add `thread_unsafe` as an alias of `parallel_threads(1)`. > introspect it for usage of pytest.warns to automatically do the right...

On a separate note, it seems that the latest commit in Pythran (https://github.com/serge-sans-paille/pythran/commit/b8cd84b5a5ab5222d65781a0194916ad555bf70c) introduced some compilation errors. EDIT Ralf: already captured in gh-21877.

Current errors are related to https://github.com/scipy/scipy/issues/21885

As @FrancescAlted mentioned, it is not recommended to modify private attributes from an external library, since any change or removal of these might incur in code breakages downstream. In this...

@ikrommyd sorry for the confusion, what I meant is to initialize the private numexpr dictionaries like numexpr does in case you are depending on them, that shouldn't affect numexpr initialization,...

I've just opened https://github.com/dtolnay/cxx/pull/831, that should fix the duplicate const const.

@ofek, could you please provide a reproducible example? If I spawn a process locally it works as expected: ```python >>> from winpty import PtyProcess >>> p = PtyProcess.spawn(['python.exe', '-c', 'print(input("input:"))'])...