POST variables not serializing properly

[erikreedstrom]

The request payload of when using POST method passes variables as JSON string rather than object.

Expected

{
  "query": "mutation UpsertCustomer...",
  "variables": {
    "homepolish_id": 421,
    "input":{ "age": 36 }
  },
  "operationName":"UpsertCustomer"
}

Actual

{
  "query": "mutation UpsertCustomer...",
  "variables": "{"homepolish_id": 421, "input": {"age": 36}}",
  "operationName": "UpsertCustomer"
}

[lilyball]

This is a major issue. It makes GraphQL IDE.app completely useless for any queries that include variables.

[lilyball]

I guess not completely useless. It turns out GET works. I was told to use POST with our GraphQL server but apparently that's not actually a requirement.

[lilyball]

The following diff appears to fix the bug:

diff --git a/src/app/components/project-detail/project-detail.jsx b/src/app/components/project-detail/project-detail.jsx
index 223b2c4..c923713 100644
--- a/src/app/components/project-detail/project-detail.jsx
+++ b/src/app/components/project-detail/project-detail.jsx
@@ -509,6 +509,17 @@ export default ({store, actionCreators, selectors, queries, factories, history,
                 return
             }
 
+            let queryVariables = null
+            try {
+                const variablesStr = query.get('variables')
+                if (variablesStr != '') {
+                    queryVariables = JSON.parse(variablesStr)
+                }
+            } catch (e) {
+                swal("Error", "The query variables are not valid JSON.", "error")
+                return
+            }
+
             const startTime = moment()
 
             this.props.tabsUpdate({
@@ -535,7 +546,7 @@ export default ({store, actionCreators, selectors, queries, factories, history,
                 params: {
                     query: query.get('query'),
                     operationName: query.get('operationName'),
-                    variables: query.get('variables')
+                    variables: queryVariables
                 }
             })
 

[aponski]

Unfortunately for me this app is useless because of this bug.

[fbjork]

Any update on this issue?