andersundsehr
Add first functional tests
This adds the first functional tests for aus_driver_amazon_s3.
The tests are run against a local MinIO instance that is started with the container that the tests are run in.
A prepared test-bucket is provided that MinIO can use without initial setup, which keeps test setup time low and keeps dependencies at minimum.
Some of the tests are marked skipped because they exhibit bugs that get fixed with #147.
The functional tests do not yet get automatically run on github actions since I don't know how to do that properly.
I run the tests locally with
time ./Build/Scripts/runTests.sh -p 8.2 -d sqlite -s functional -e "--display-warnings --display-notices --display-errors"
and they complete in 3 seconds.
I've added the functional tests to the github actions file, but they do not run automatically:
This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs.
Thank you @cweiske I changed some of the scripts around the tests (minio setup) and others and would provide an other pullrequest you can take a look at and have an opionion about to get the best of both. With that i look forward to extend the functional tests a lot to cover most code in future.
@cweiske
I pushed it to https://github.com/andersundsehr/aus_driver_amazon_s3/tree/functional-tests-alternative the idea i had was to update to recent test scripts from the actual blog_example and to create the minio data on test runtime so its easier to change its content.
feel free to tell me if there are reasons not to do as i did.
Did you change my commits? I don't see any commits of yours.
I used a set of predefined files in minio because that makes the test runs faster.
@cweiske you are right. the commit did not succeed it is now added.
i hope i have some time soon to get things together and have a master merge
@weakbit could you please merge the tests as they are, so that the other patches can use the tests as base?
I understand if you want to change things, but they do work as they are. If you don't have time to rework them now, merge my code and rework it later.
Having non-optimal tests now is better than perfect ones in 3 years.
@cweiske thats right, could you please fix the conflict, then i will merge your PR