qdl icon indicating copy to clipboard operation
qdl copied to clipboard

*added version info and build time info

Open AMV007 opened this issue 1 year ago • 1 comments

*added vscode settings to exclude *max_payload_size to more clear size

AMV007 avatar Jun 07 '24 09:06 AMV007

couple points:

  • this is all good improvements
  • most of the commiters here are used to the linux kernel way of structuring changes (one change per commit), but that's not a big deal for me with such small patches
  • qdl (lowercase) seems to be the used throughout the codebase
  • I think having a git hash in the print would be very useful (say qdl version 1.0.0-1234abde)
  • the date could use a LC_ALL=C in the front
  • since i added so many nits, I may as well ask to put a space between the * and the operands in the max_payload_size declaration :wink:

thanks!

konradybcio avatar Jun 07 '24 20:06 konradybcio

Resolved by PR #90

andersson avatar Jan 21 '25 17:01 andersson