qdl icon indicating copy to clipboard operation
qdl copied to clipboard

Published 20 hours ago • verified publisher icon andersson

Implement sparse image support

Open obbardc opened this issue 2 years ago • 4 comments

Based on original work from https://github.com/andersson/qdl/pull/5

Signed-off-by: Christopher Obbard [email protected]

obbardc avatar Jun 29 '22 15:06 obbardc

cc @blenk92 @abozhinov444 @andersson @jwinarske @ndechesne

obbardc avatar Jun 29 '22 15:06 obbardc

thanks for sending this PR.. support for sparse support is very much needed.. I am wondering if using libsparse is really a great thing though. First the distribution of libsparse in distro is not always great (I don't think Archlinux has it), and hardcoding the lib path like you did is problematic. Also, I think it complicates the main loop when processing the file quite a bit.. how difficult (or wrong?) would it be to implement a small 'unsparse' algorithm directly in qdl? would that be a bad idea?

ndechesne avatar Jun 29 '22 16:06 ndechesne

@ndechesne I agree. It would be better to not pull in library dependency, and implement the sparse algorithm directly.

jwinarske avatar Jun 29 '22 17:06 jwinarske

Right, using the library is a bit of a pain. The other two open PRs vendor in libsparse. If that is acceptable, I can do that here too?

obbardc avatar Jun 29 '22 17:06 obbardc