disgord icon indicating copy to clipboard operation
disgord copied to clipboard

style: interaction data

Open beachasaurus-rex opened this issue 2 years ago • 1 comments

Description

Changing the interaction data types so that they're more aligned with discord's API. The main goal of this refactoring is to help disgord users express what is actually happening during interactions. In other words, if the user intends to receive an interaction object message component, then the user should receive the equivalent from disgord.

Interaction data is polymorphic, so this PR shows 1 way to achieve that a bit better in disgord.

Interaction callback data is also polymorphic, so this PR shows 1 way to achieve that a bit better in disgord.

Breaking Change?

yes

Benchmarks

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] Commented complex situations or referenced the discord documentation
  • [ ] Updated documentation
  • [ ] Added/Updated unit tests
  • [ ] Added/Updated benchmarks (if this is a performance critical component)

beachasaurus-rex avatar Jul 31 '22 05:07 beachasaurus-rex

I know that a good chunk of the internal stuff would need to change for this to even work, but I want to get feedback on at least the surface-level API changes I've made so far.

beachasaurus-rex avatar Jul 31 '22 14:07 beachasaurus-rex