l5-repository icon indicating copy to clipboard operation
l5-repository copied to clipboard

Trait `CacheableRepository` - `getCacheMinutes` method was removed without breaking version?

Open coelsman opened this issue 4 years ago • 1 comments
trafficstars

From version 2.7.7 to 2.7.9, method getCacheMinutes had been replaced by getCacheTime. As I investigated, the origin PR (#762) was marked as breaking changes, the released version must be 2.8 or whatever like that.

Follow new changes, I suggest:

  • Keep origin getCacheMinutes method.
  • Write new method called getCacheSeconds.
  • Method getCacheTime: handle difference of ttl between Laravel version and call correspond method above.

coelsman avatar Oct 18 '21 09:10 coelsman

I am open to PR about this @coelsman :)

bsormagec avatar Oct 23 '21 07:10 bsormagec