l5-repository icon indicating copy to clipboard operation
l5-repository copied to clipboard

Working code broken after update to 2.6.35

Open rubavz opened this issue 5 years ago • 2 comments

Hello my code was working very well with your package version 2.6.32 but after updating to current version 2.6.35, it broke specifically because the update to function

count () to count( params ) , i think it would be great to maintain backwards compatibility adding a new declaration ? and deprecating existing count?

rubavz avatar Sep 06 '19 05:09 rubavz

Hi @rubavz,

we're getting the same issue. Did you solve someway?

Cheers

encodiaweb avatar Sep 06 '19 06:09 encodiaweb

Just encountered the same issue. We have a subclass of Prettus\Repository\Eloquent\BaseRepository that implements our own count() method and after updating to 2.6.35 the method causes a signature mismatch error. Fortunately the new count() is compatible with our own so we just switch to the new one and remove our own.

monyxie avatar Sep 10 '19 02:09 monyxie