paystack-python icon indicating copy to clipboard operation
paystack-python copied to clipboard

No options for query parameters for transaction listing

Open Strapchay opened this issue 10 months ago • 4 comments

There is no options for query parameter when using the transaction class. For example using paystacks plain url, its possible to do something like: f"https://api.paystack.co/transaction?use_cursor=true&perPage=10&customer={x}" But the list endpoint for the transaction doesn't receive any params.

Strapchay avatar Apr 13 '24 20:04 Strapchay

Have made a pull requests that addresses this issue since its more or less a low handing fruit: https://github.com/andela-sjames/paystack-python/pull/93

Strapchay avatar Apr 13 '24 21:04 Strapchay

Hey @Strapchay Facing the same issue, was coming to make a PR on the query params for that resource but seems you've done that already. Any status on whether it went in?

sharhan-alhassan avatar Jul 22 '24 16:07 sharhan-alhassan

I had no issues using the data, there might be a possibility if the pull request not being accepted or not being accepted within your needed time frame, so I would advice you should either fork my repo or create a repo for yourself and use the forked repo in your project

Strapchay avatar Jul 22 '24 17:07 Strapchay

I had no issues using the data, there might be a possibility if the pull request not being accepted or not being accepted within your needed time frame, so I would advice you should either fork my repo or create a repo for yourself and use the forked repo in your project

Hey buddy, that sounds good to me. Thank you

sharhan-alhassan avatar Jul 22 '24 19:07 sharhan-alhassan

Thanks for making the changes, let me update this

andela-sjames avatar Jul 24 '24 20:07 andela-sjames

Thanks for making the changes, let me update this

Thank you @andela-sjames I'll be opening another issue and a possible PR on that for Subscription resource

sharhan-alhassan avatar Jul 24 '24 21:07 sharhan-alhassan

Thanks for making the changes, let me update this

Thank you @andela-sjames I'll be opening another issue and a possible PR on that for Subscription resource

Please don't forget to update the doc folder and test if possible on the next PR, I will release an update in a moment

andela-sjames avatar Jul 24 '24 21:07 andela-sjames

Thanks for making the changes, let me update this

Thank you @andela-sjames I'll be opening another issue and a possible PR on that for Subscription resource

Please don't forget to update the doc folder and test if possible on the next PR, I will release an update in a moment

Awesome! Will definitely do that

sharhan-alhassan avatar Jul 24 '24 21:07 sharhan-alhassan