Andrew Fort
Andrew Fort
In our present usages, one area we've run into a concern with not having prefixes is for type names - since types are often pulled in from other modules (e.g.,...
I'm not in favor of _removing_ the `pattern` statements. The pattern statements in these modules were originally correct and were made incorrect by updates. It's a bad idea to remove...
Thanks, Anees; I agree, either of these approaches will fix the bug that we and others are working around. I'm suggesting both approaches for the reasons you list. I'm certainly...
Thanks, would agree the call `compare(1)` is in error. This sort function is designed to sort an incoming string (from some `error.Error()`) by filename, then line number, column number and...
It would be fantastic if we could keep the incorrect spelling of "descendents", just because they're a great band :). Cheers, Andrew On Wed, Jul 19, 2017 at 10:16 AM,...
Paul, thanks for the response. Sounds like a fine approach, I'll start a new branch with those changes. While I guess we haven't reached a "stable" version yet, have you...
Hi, I side with Rob's "option 2", but to be honest I don't have a great argument as to why. My concerns about the effect upon users (existing as well...
@pborman Thanks, I'd considered and forgotten about that. I'd also considered adding an accessor method to the concrete type to retrieve the appropriate value from the singular or plural field...
@LeonGWang So if I understand correctly, the choices are to: 1. change the 1-ary field to a slice (though we don't have a full agreement yet on `HEAD` versus new...
Sorry, I missed the updates here. Obviously we have conflicts now, which I'd be happy to help resolve given the delays. The changes made here look fine to me, is...