and3rson
Thanks! Plus some first impressions. :)
Thanks for your work on this library--I think it's a really useful tool for adding additional functionality to Godot.
I've finally recently gotten into working on one of the projects that I was interested in Godot libffi support for, so now have some actual experience with the current Foreigner implementation. :) So thought some initial feedback might be of use (this was on Linux):
-
For my project I needed to pass arbitrary byte sequences containing
null/0x00/zero bytes so the existing string-based support wasn't sufficient. I've created a draft PR with what "worked for me" enough to move on to the next step on my project--but the PR requires further work to be robust. -
Hit a couple of small documentation issues, plan to add some PRs for those.
-
Also had some thoughts about potential implementation changes that might improve cross-platform support & deployment. ~~May~~ Created separate issue for this (https://github.com/and3rson/foreigner/issues/8)--but it turns out the Godot functionality I thought might be useful isn't currently exposed via GDNative.
-
Also related to deployment, I think it would great to have prebuilt binaries via CI to help adoption. Realise this is non-trivial amount of additional work but will try to add at least an issue to track this possibility. (added)
Feel free to close this issue, as it's primarily a FYI but wanted to express my appreciation for your work and give some context to my other PRs & issues. :)
Edits: I knew there was something else, added another bullet point. :) Added links to issues/PRs.
Hi,
Thank you for your feedback! I'm very happy that my progress so far is useful for others.
I totally like the points that you've highlighted. I've been rather busy recently and haven't maintained foreigner much, so your PRs are very welcome!
