Allow configuring timeout for external sources

[pouyan021]

This pull request closes #1624. It adds and enforces the ability to set a new property abort-after to external sources. As discussed in the issue, it supports both a global prop and a maven property that overrides the global if it is set.

[spiffcs]

@pouyan021 Approved and running checks now - Thank you so much for the contribution!

[spiffcs]

@pouyan021 looks like there is a small change needed where go mod tidy is run

[pouyan021]

@spiffcs Appreciate your support, thanks a lot! The problem with go.mod is addressed but I forgot to sign-off my commit! I fixed that and pushed again. Could you kindly approve the checks once more?

[wagoodman]

note: I force pushed to get this branch rebased onto the latest commit on main

[pouyan021]

Overall the functionality looks good, but have some comments on testing and configuration. I'll push up some changes shortly to help out.

I do think that RequestTimeout is a better name for this config item -- what do you think @pouyan021 ?

Hey @wagoodman thanks a lot for the thorough review and your additional changes. The name was chosen as abort-after based on the suggestion by one of the contributors here. I agree with you that RequestTimeout is more self-explanatory.

[pouyan021]

Hey @wagoodman should I go for the requestTimeout as per your suggestion?

[pouyan021]

Hey @wagoodman @spiffcs I resolved the conflict on this branch recently, any plans for this to move forward?

[spiffcs]

@pouyan021 I'm so sorry here - I've approved and have run the final checks and will get this merged - I did not see the notification for this and apologize for letting it sit

I'll get the commits in the wrap this up 😄

[pouyan021]

Hey @spiffcs, I rebased this branch again, could you please trigger the checks so we can hopefully merge this?

[pouyan021]

cc @wagoodman