anchor-cms icon indicating copy to clipboard operation
anchor-cms copied to clipboard

Published 20 hours ago • verified publisher icon anchorcms

Can't upgrade from 0.12.6 -> 0.12.7

Open marc0tjevp opened this issue 6 years ago • 8 comments

Summary

When promped with an upgrade, the download buttons does not work, clicking it returns sendAjax is not a function in the console.

Expected Behaviour

The upgrade downloads and is applied.

Actual Behaviour

  • Log in into admin environment
  • Get promped with upgrade
  • Download button does not work

Context details (if applicable)

  • Anchor version: 0.12.6
  • Server setup: Apache/2.4.29 (Unix)

marc0tjevp avatar Mar 07 '18 10:03 marc0tjevp

@marc0tjevp That's an odd one; mind trying it again?

CraigChilds94 avatar Mar 07 '18 12:03 CraigChilds94

@CraigChilds94 I just tried again, still the same result.

marc0tjevp avatar Mar 08 '18 00:03 marc0tjevp

I received a dancing robot... What's the network tab say? Maybe there's an issue with how it grabs the zip from GitHub?

On Thu, Mar 8, 2018 at 9:42 AM, Marco van Poortvliet < [email protected]> wrote:

@CraigChilds94 https://github.com/craigchilds94 I just tried again, still the same result.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/anchorcms/anchor-cms/issues/1269#issuecomment-371331647, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbfK8LkPgAK-ZIyklqiUiYJDMiNHnX5ks5tcHdlgaJpZM4SgOFd .

TheBrenny avatar Mar 08 '18 08:03 TheBrenny

I'm having this problem as well, trying to go from 0.12.3 to 0.12.7. Attached screenshot of the console error. screen shot 2018-03-12 at 11 31 18 am

joshvickerson avatar Mar 12 '18 15:03 joshvickerson

@TheBrenny Checked the network tab, there's no request. Clicking the button just adds a # to the url.

marc0tjevp avatar Mar 14 '18 20:03 marc0tjevp

wow, Zepto again. From what @TheBrenny just said, I'd guess the the handler for the button is malformed. From @joshvickerson's stacktrace, it looks like the event is firing and request is sending, but the response is not not what's expected.

Could be another push towards that Vanilla rewrite we talked about. All these JS bugs might shake out if we just refactored Zepto out of the picture...

evansharp avatar Aug 09 '18 16:08 evansharp

@evansharp The stacktrace also looks like it's more an issue with what the server is sending back; ie, it's not actually sending a JSON response... This usually happens becuase we (probably I) may have missed a step in setting the return to be JSON instead of HTML.

TheBrenny avatar Aug 10 '18 07:08 TheBrenny

@TheBrenny But of course if we replaced Zepto, bugs like that would come out in the wash ;)

evansharp avatar Aug 19 '18 20:08 evansharp