Code review will not fail automatically in case of issues

For some reason, there was an issue with the review and action didn't cancel until the 6-hour timeout had elapsed
@@ -6,6 +6,7 @@
import lombok.Getter;
import java.math.BigDecimal;
import java.math.RoundingMode;
@Getter
@Builder(access = AccessLevel.PRIVATE)
@@ -21,6 +22,8 @@ public class SubscriptionPlanDto {
public static SubscriptionPlanDto NONE() {
// TODO: ꡬλ
μλ κ²½μ° μ΄λ»κ² μ²λ¦¬? (νλ‘μ°)
return SubscriptionPlanDto.builder()
.planCode("")
.price(BigDecimal.ZERO)
.name("μ΄μ©μ€μΈ μλΉμ€ μμ")
.isActive(false)
.build();
@@ -34,7 +37,7 @@ public static SubscriptionPlanDto of(SubscriptionPlan plan) {
.description(plan.getDescription())
.planCode(plan.getPlanCode())
.price(plan.getPrice())
.priceIncludeVat(plan.getPrice().multiply(BigDecimal.valueOf(1.1)))
.priceIncludeVat(plan.getPrice().multiply(BigDecimal.valueOf(1.1)).setScale(0, RoundingMode.FLOOR)) // 1μλ¨μ μ μ
.isActive(plan.getIsActive())
.build();
}
This code that tried, just simple
@headless-kjh Actually I have no idea what causes this. could you help to re-run the job, let's check if it doesn't exit for the PR every time
I think the focus should be on the fact that the function does not terminate when a problem occurs, rather than on the cause of the problem itself. No errors occurred during the "re-run".
OpenAI has really bad uptime, that could be the issue.
Are we sure this is being handled correctly?
https://status.openai.com
We have the same error again today. It's not a special case. It seems that failure timeout or retry is necessary.