anbox-installer icon indicating copy to clipboard operation
anbox-installer copied to clipboard

installer.sh should run with "set -e" so it stops processing on errors

Open ogra1 opened this issue 7 years ago • 2 comments

currently a failure of any sub-call of the installer script will not stop the installation... i.e. if the dkms compilation fails it will still move on and install all the script snippets and session jobs ... it should instead stop processing and not move on putting stuff in place. this is also helpful to make it clearer to endusers that something went wrong.

ogra1 avatar Apr 19 '17 14:04 ogra1

We run with -e for certain portions of the installer script. Especially for those where we install the dkms package. Or do I miss anything?

morphis avatar Apr 21 '17 17:04 morphis

Well, I have seen quite a few logs where dkms failed but the script just moved on. A toplevel "set -e" right after the shebang should help... If not, we should add more error checking add for the particular bits.

ogra1 avatar Apr 21 '17 19:04 ogra1