André Bargull

Results 143 comments of André Bargull

Language subtags are 2-3 or 5-8 alphabetic characters. | Code | Result | |----|----| | `new Intl.Locale("x").language` | `RangeError` | | `new Intl.Locale("xx").language` | `"xx"` | | `new Intl.Locale("xxx").language` |...

Using `new Date(1970)` is a bit confusing, because it can easily be misinterpreted as creating a Date object for the year 1970, even though it's actually creating a Date object...

> ```js > var s1 = new Date(1970); > Object.defineProperty(s1, "toString", { > value: Boolean.prototype.toString > }); > assert.throws(TypeError, () => { > s1.toString(); > }); > ``` 145913a3d9648075bb4e9b912a98735b8dcb99c2 also...

> I wanted an indication of the Date constructor changes made for Hardened JavaScript and chose `1970`. Admittedly, it could be misleading. Is there another value that could be used...

This is necessary for compatibility with Temporal (for example ) and if offsets exceed 24 hours, it's also no longer possible to parse string representations of the offset through [UTCOffset](https://tc39.es/ecma262/#prod-UTCOffset),...

`ToDateTimeOptions` will be removed, if #709 gets accepted.

Is [AsyncDisposableStack.prototype.disposeAsync](https://arai-a.github.io/ecma262-compare/?pr=3000&id=sec-asyncdisposablestack.prototype.disposeAsync) an "async built-in method" (#2942). It calls the [DisposeResources](https://arai-a.github.io/ecma262-compare/?pr=3000&id=sec-disposeresources) AO, which performs Await.

`day_of_month` can return zero for some dates when using the non-always-calculating constructor. That's probably a related issue: ```rs use icu::calendar::Date; use icu::calendar::Calendar; use icu::calendar::islamic::IslamicObservational; fn main() { // let cal...

( depends on these change. This is mentioned in the commit messages for the other PR, but not in the description, so explicitly mention it here so that GH can...

Possibly caused by this line: https://github.com/unicode-org/icu4x/blob/6d65cb511267b5f7b91fd18db120a37f44ddf615/components/calendar/src/indian.rs#L153 Changing the test condition from `>= days_in_year` to `> days_in_year` could fix this bug.