Angelika Schneider

Results 24 comments of Angelika Schneider

Futhermore, if we deploy Assessment and Orchestrator independently, we need to specify the bundles folders for both. We should solve this better as well.

"signInActivity" is only available with Azure AD Premium P1/P2 license [link](https://learn.microsoft.com/en-us/graph/api/resources/user?view=graph-rest-1.0). Azure AD Premium P1 5,60€/User [Link](https://www.microsoft.com/de-de/security/business/identity-access/azure-active-directory-pricing)

I like more the upper one with the filter embedded in the message.

``` // TODO(oxisto): This is not very efficient, we should do this once at startup so that we can just return the map for _, metric := range metrics {...

I don't know why these are not used anymore. But I think we should refactor the tests in service/orchestrator/catalogs_test.go and use the "MockControls" instead of rewriting the controls for each...

Regarding MockControlsInScopeSubControl4: I think that was forgotten in the MockControlsInScope slice. I think we should it to the slice.

The variables/constants in testdata all appear to be used.

We can close this issue, the current validation function checks this.