Angelika Schneider comments

Results 24 comments of


                                            Angelika Schneider

Discovery: Azure ARM template discovery needs a mayor update

#739 removes the Azure ARM template discovery file and test file for now, as too many changes need to be made.

Add check for existing resourceTypes in assessment result

@oxisto can we now merge that to main?

Check if evidence and assessmentResult is nil

Error does not occur anymore.

Check if evidence and assessmentResult is nil

But the validate() function checks that case, or not?

Azure Discovery: BootLogging.retentionPeriod is always set to "0"

Maybe you should leave the value at 0, because you can't tell when the data will be deleted. But we would have to consider what the value 0 means (will...

Errors should be treated equally

I think we once had this question about printing error messages, but I'm not sure how we decided back then: Do we print the error message where it occurs (e.g....

Errors should be treated equally

- How to wrap the error message: %v, %w, %s, ... - Where to print the error message: where it occurs vs. at the "highest" level #438 - Should tests...

Concretize error message in assessment component

Maybe the important resource fields should be checked in the Validate() function?

Concretize error message in assessment component

> What was the input resulting in that error message? The problem is that we only have a map and no struct. And the values of that map are checked...

Update GetMetricConfiguration description

The following should be checked in an separate PR/Issue. UpdateMetricConfiguration - [ ] isDefault is not updated, if not available in request -> set to false - [ ] grpc...