nova-import icon indicating copy to clipboard operation
nova-import copied to clipboard

Published 20 hours ago • verified publisher icon anaseqal

Fix for nova 4

Open ronvanderheijden opened this issue 2 years ago • 6 comments

  • added abstract menu function

ronvanderheijden avatar Sep 01 '22 13:09 ronvanderheijden

Closes: #36

ronvanderheijden avatar Sep 01 '22 13:09 ronvanderheijden

@anaseqal Do you think you can take a look at this contribution?

dmyers avatar Feb 21 '23 20:02 dmyers

@anaseqal Do you think you can take a look at this contribution?

Nova4 use vue3. Cannot just add a menu to make it work on nova4

anditsung avatar Feb 21 '23 22:02 anditsung

@anditsung The code is broken, this fix has nothing to do with vue3 or any other front-end parts.

ronvanderheijden avatar Feb 23 '23 08:02 ronvanderheijden

code is definitely broken but only fix the compatibility on nova4 without updating the frontend still cant be use on nova4

anditsung avatar Feb 23 '23 08:02 anditsung

I've tested it and it's working properly. You aren't even using this menu feature, so I don't get your comment. Anyway, You can close this pull-request. I'll be using the fork, which does the trick.

ronvanderheijden avatar Feb 23 '23 08:02 ronvanderheijden