python-artifactory icon indicating copy to clipboard operation
python-artifactory copied to clipboard

Feature: Added federated repo type

Open dakky opened this issue 1 year ago • 1 comments

Description

Artifactory provides in a new Type of Repo: federated. this is basically a local repo, except that the model has a field members, which contains URLs to other artifactory instances and replicated (bi-directional) the content between these instances

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

How has it been tested ?

  • [x] pytest ;)
  • [x] Integration test:
    from __future__ import annotations
    
    from pyartifactory import Artifactory
    from pyartifactory.models import FederatedRepository, LocalRepository
    
    art = Artifactory(
        url="https://URL/artifactory",
        auth=("XXX", "XXX"),
        verify=False,
    )
    
    # testing of "old" behavior still works fine
    local_repo = LocalRepository(key="local_test")
    new_local_repo = art.repositories.create_repo(local_repo)
    
    # testing if federated repo creation works
    fed_repo = FederatedRepository(key="test2")
    new_fed_repo = art.repositories.create_repo(fed_repo)
    

Checklist:

  • [x] My PR is ready for prime time! Otherwise use the "Draft PR" feature
  • [x] All commits have a correct title
  • [x] Readme has been updated
  • [x] Quality tests are green (see Codacy)
  • [x] Automated tests are green (see pipeline)

dakky avatar Mar 14 '24 07:03 dakky

Thanks @dakky for your contribution, sorry for the delay for reviewing your changes. There are just a few things to change for the MR to be approved

anancarv avatar Mar 28 '24 14:03 anancarv

hmm somethings wrong with the codacy token?

dakky avatar Apr 25 '24 11:04 dakky

hmm somethings wrong with the codacy token?

It's ok. It's a known problem. It is because you don't have the codacy token on the settings of you forked repo.

anancarv avatar Apr 25 '24 13:04 anancarv