analog icon indicating copy to clipboard operation
analog copied to clipboard

WIP: docs: create docs on integrating with storybook

Open RyanClementsHax opened this issue 1 year ago • 5 comments

PR Checklist

Part of https://github.com/brandonroberts/angular-v17-vite-storybook/issues/7

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/analogjs/analog/blob/main/CONTRIBUTING.md#-commit-message-guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Documentation content changes
  • [ ] Other... Please describe:

Which package are you modifying?

  • [ ] vite-plugin-angular
  • [ ] vite-plugin-nitro
  • [ ] vitest-angular
  • [ ] astro-angular
  • [ ] create-analog
  • [ ] router
  • [ ] platform
  • [ ] content
  • [ ] nx-plugin
  • [ ] trpc

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Awesome

RyanClementsHax avatar Jun 18 '24 00:06 RyanClementsHax

Deploy Preview for analog-blog ready!

Name Link
Latest commit e0df799ab319ed5294ab961231958354ff47a18a
Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6670d778641d8e000838b2b6
Deploy Preview https://deploy-preview-1170--analog-blog.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 18 '24 00:06 netlify[bot]

Deploy Preview for analog-ng-app ready!

Name Link
Latest commit e0df799ab319ed5294ab961231958354ff47a18a
Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/6670d7783ebfaf0008299feb
Deploy Preview https://deploy-preview-1170--analog-ng-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 18 '24 00:06 netlify[bot]

Deploy Preview for analog-docs ready!

Name Link
Latest commit e0df799ab319ed5294ab961231958354ff47a18a
Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6670d778bfd0b40008b4be30
Deploy Preview https://deploy-preview-1170--analog-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 18 '24 00:06 netlify[bot]

Deploy Preview for analog-app ready!

Name Link
Latest commit e0df799ab319ed5294ab961231958354ff47a18a
Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6670d77874466900081cf437
Deploy Preview https://deploy-preview-1170--analog-app.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 18 '24 00:06 netlify[bot]

@brandonroberts consider this to be WIP. I'm testing this on a mantis project to see if it will hold in a different type of project. So far I'm getting Cannot destructure property 'id' of 'defaultExport' as it is undefined. errors.

My work is on this branch if you want to follow https://github.com/RyanClementsHax/nx-storybook-repro/tree/storybook-analog

npm i
npx nx storybook web-client

RyanClementsHax avatar Jun 18 '24 00:06 RyanClementsHax

FYI work has been crazy and getting free time has been difficult. I'll try to work on this when I can but won't be offended if someone has to take this over.

cc @brandonroberts

RyanClementsHax avatar Jul 20 '24 22:07 RyanClementsHax

@RyanClementsHax no problem. Will do

brandonroberts avatar Jul 21 '24 21:07 brandonroberts