scopy icon indicating copy to clipboard operation
scopy copied to clipboard

plugin: Add ADMT Plugin for ADMT4000

Open JJuanill opened this issue 1 year ago • 2 comments

Adding implementation of ADMT4000 Harmonic Calibration plugin to Scopy

JJuanill avatar Jan 17 '25 10:01 JJuanill

I see the PR is still in progess, but I noticed a few things that might need changing before this is ready for complete review.

  • create an xml for emulator so we can test the plugin without needing the hardware (https://github.com/analogdevicesinc/iio-emu/tree/main/tools)
  • format code using clang-format version 10 (run tools/format.sh)
  • revert change in the main CMakeLists.txt
  • admt/CMakeLists:
    • remove unused liked libs from cmake (scopy-gr-util, scopy-iio-widgets)
    • remove UI_LIST uses
  • all larger stylesheets from inside .cpp files should be moved to qss using the style infrastructure
  • migrate admtstylehelper.cpp to qss style and use Style::getChannelColor instead of redefining colors
  • HorizontalSpinBox::setEnabled argument should be bool ?
  • rebase with main

andrei47w avatar Feb 03 '25 09:02 andrei47w

This looks good ..

Can you clean up the commit history a little bit ? We can also squash and have a single commit for this pull request.

adisuciu avatar Mar 20 '25 11:03 adisuciu